Added fix for upstream pipeline failure. #3504
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gswami91
force-pushed
the
fix_upstream_pipeline
branch
2 times, most recently
from
611c876
to
25415ef
Compare
edewata
reviewed
Apr 26, 2021
| --ansible-module-path tests/dogtag/pytest-ansible/common-modules \ | ||
| --junit-xml pki_cert_scep_1664435_junit.xml \ | ||
| -qsvvv \ | ||
| tests/dogtag/pytest-ansible/pytest/ca/scep/test_bug_1664435_pki_ca_scep_enrollment.py |
There was a problem hiding this comment.
Is it possible to merge this into the previous step (lines 100-110) so we don't have to keep modifying the workflow whenever we add new tests?
There was a problem hiding this comment.
I added this as per my previous job (https://github.com/dogtagpki/pki/pull/3351/files)
Should I add jobs as below?
-qsvvv \
tests/dogtag/pytest-ansible/pytest/sanity/test_role_users.py
tests/dogtag/pytest-ansible/pytest/ca/scep/test_bug_1664435_pki_ca_scep_enrollment.py
There was a problem hiding this comment.
I'm thinking the SCEP test should be added into tests/dogtag/pytest-ansible/pytest/sanity/test_role_users.py so that if we want to run sanity test manually we only need to run just that one file (assuming SCEP test is part of sanity test).
gswami91
force-pushed
the
fix_upstream_pipeline
branch
6 times, most recently
from
f4ff01e
to
2d824f6
Compare
|
@gswami90 Hi, I've fixed the missing pip3 issue. Could you rebase the PR? Thanks. |
…pki/-/pipelines/291988444 Signed-off-by: Gaurav Swami <[email protected]>
gswami91
force-pushed
the
fix_upstream_pipeline
branch
from
2d824f6
to
87356f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added fix for upstream pipeline failure https://gitlab.com/dogtagpki/pki/-/pipelines/291988444
Signed-off-by: Gaurav Swami [email protected]